wcst_import: more meaningful type names

[Bang Pham Huu]

It looks like when import data with wcst-import (base/mdd/set) type is using an encrypted to make random string like

set

typedef set <zhyZwfhgLBcsyppsRoaCVfuhOknmcz> PJJPOvMITBaqExHqukFxHsdUXMXNZr;
typedef set <nQwXcEnmcTavrohjjnDjPHBiaZkHEi> PIdZXPOnBZTrUbnkSfjnYNrfGawnIv;
typedef set <RlNDbCvZiRvONsXGzpoFZiTPGzLoRG> RwpTfQMnNWVEIqgpgxyYZZtCaciNuG;

mdd

typedef marray <struct { short VHCYPEbfqIrhzCXzvlyImpUOOMJQwe, short NRHjCIZDseunvLNCkhzhruSaudsDpx, short lUpQFtfuQWbcQaOOfjeqJCnSHulrJF, short wKcWEEHKLiZYGyzYrJBlFySgwXUUjd, short wmyWVhbAlPnGITJUmaRKXOgNjIpgBO, short qYjkYPxaUQiKzphdXLKofVyWaQSDCV }, 2> zhyZwfhgLBcsyppsRoaCVfuhOknmcz;

and base

typedef struct { char OHMtfojPLTkGeumJNJlpeIkHNATlhI, char COibkSRwNrTChpxJTjbpRKMztkjgEK, char sDmhvgGbMtanbLApupZFoBUoafoapG } zVQjPHtQWdPIIwEmLuXLCSxiyelmzm;

I think this is very hard to manage definition data in RASDAMAN if user have to deal which this kind of naming convention. I would like to also propose that we should not do this (anyway from my point so you can have another idea).

If I could have a chance to change, I would like based on "coverage_id" in recipe to create the name of "base/mdd/type". Suppose I import data with wcst-import with "coverage_id": "Landsat8-Band1-3" and what I want to see when using rasdl —print is

typedef struct { char a, char b, char c} Lansat8-Band1-3_base  # I have no idea why not just use character from a, b, c... or a1 .... a10000 instead of random string like current imported data.

or

typedef marrray<struct {char a1, char a2, char a3}, 2>Landsat8-Band1-3_mdd

and

typedef <Landsat8-Band1-3_mdd>Landsat8-Band1-3_set

I think it is very helpful if it could like my example.

Thanks,

PS: As Dimitar mentioned 'We can always append some random bits in case there's a type name clash'. May I know which case Rasdaman will allow to add the base/mdd/type that is existed in RASBASE? (From my view this is an error).

Here is my example

Reading rasdaman data definition file /home/rasdaman/rasdl.type...inserting symbols into database...EDL003 rasdaman error: 905: Evaluation error 905 in line 2, column 1, near token abcPixel: Struct type name exists already.
rasdl done

and if using wcst_import with the same "coverage_id" then it will have an error when 2 different coverages using same "coverage_id" but has different structures (for example: 1 is GreySet, 1 is RGBSet). If it is the same structure then it should be update to the "coverage_id".

[Dimitar Misev]

I think this is a petascope WCS-T ticket.

[Dimitar Misev]

This is very similar to #1055, they can be done together.

[Dimitar Misev]

This has not been fixed as far as I can see, we still have random types. This is especially a problem with band names when using rasql fragments in WMS 1.3, the wcst_import band names do not match the rasql ones and it's necessary to use indexes in the query (or random band names).

[Alex Dumitru]

I guess only the struct type names are important in this case. Maybe we can just name them the same as the bands? It would be a bit confusing though as for existing types the rule would not be followed anymore, so maybe a new type for each coverage might be best.

Vlad what do you think?

[Vlad Merticariu]

It seems ok for the type name to be given by the band names. In case of conflicts, I guess we can add some suffix.

[Dimitar Misev]

I don't expect any conflict in the band names case. It's sufficient if newly imported coverages follow this in my opinion, I wouldn't bother updating the types of existing ones.

[Dimitar Misev]

I'd suggest for set/array/struct cell types:

• CovID_Set
• CovID_Array
• CovID_Cell

For the bands, by default we can name them band1, band2, band3, ..