WCS-T doesn't support CInt16

[Dimitar Misev]

While importing Sentinel 1 SLC data with wcst_import.sh:

Service Call: http://localhost:8080/rasdaman/ows?service=WCS&version=2.0.1&request=InsertCoverage&coverageRef=file:///tmp/ce86a214_1004_4b81_875a_6c7813ae6727.gml&tiling=ALIGNED [0:1023, 0:1023]&pixelDataType=CInt16&useId=existing
Error Code: InvalidParameterValue
Error Text: <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<ows:ExceptionReport version="2.0.0"
    xsd:schemaLocation="http://www.opengis.net/ows/2.0 http://schemas.opengis.net/ows/2.0/owsExceptionReport.xsd"
    xmlns:ows="http://www.opengis.net/ows/2.0" xmlns:xsd="http://www.w3.org/2001/XMLSchema-instance" xmlns:xlink="http://www.w3.org/1999/xlink">
    <ows:Exception exceptionCode="InvalidParameterValue">
        <ows:ExceptionText>Pixel data type CInt16 unknown.</ows:ExceptionText>
    </ows:Exception>

</ows:ExceptionReport>

Attached is a sample tiff file.

Rasdaman supports only 64 and 128 bit complex numbers (floating point only). We should extend this, best to match the GDAL complex number types (we are missing CInt16 and CInt32): ​http://www.gdal.org/gdal_8h.html#a22e22ce0a55036a96f652765793fb7a4

[Vlad Merticariu]

We could map that to r_Complex, but the problem is that r_Complex is 64 bit (which is the smallest complex type rasdaman supports).

Gdal supports from 16 to 64 bit complex types: ​http://www.gdal.org/gdal_8h.html#a22e22ce0a55036a96f652765793fb7a4

[Dimitar Misev]

I guess it's time to add more complex types in rasdaman?

[Peter Baumann]

a valid request indeed - Sentinel is important. Hope we can find resources - maybe someone from the community would like embark on this…

[Dimitar Misev]

Question: how should these complex types of 16 and 32 bit (signed int) be called?

Currently we have complex = float, and complexd = double.
Any suggestion for the new type names? complexShort/complexLong? complexInt16/complexInt32?

[Dimitar Misev]

Btw, can't we map this to a struct { re, im }?

[Dimitar Misev]

@Vlad did you come across the same Sentinel 1 data? How did import work out?

[Dimitar Misev]

The goal in this task is to introduce support for CInt16 (short complex) and CInt32 (long complex).

• qlparser/lex.ll - add the new keywords next to CFloat32/64
• qlparser/oql.yy - add handling analogous to TCOMPLEX1 / 2
• catalogmgr/ qlparser/ servercomm/ server/ raslib/ rasodmg/ clientcomm/ applications/rasql/ rasnetprotocol/ reladminif/ relcatalogif/ - search for COMPLEX and handle analogously the new complex types
• systemtest/testcases_mandatory - add tests for the new complex type

[Dimitar Misev]

Arsenij implemented CInt16 and CInt32 base types, and there are already CFloat32 and CFloat64 base types.

The remaining part is to update petascope/wcst_import to support these base types. There are test files in source:systemtest/testcases_mandatory/test_conversion/testdata (cint16_image.tif etc)

[Dimitar Misev]

Replying to dmisev:

Arsenij implemented CInt16 and CInt32 base types, and there are already CFloat32 and CFloat64 base types.

The remaining part is to update petascope/wcst_import to support these base types. There are test files in source:systemtest/testcases_mandatory/test_conversion/testdata (cint16_image.tif etc)

I'll close this ticket as duplicate of #1771